[TEP100] Remove Taskruns and Runs Fields for PipelineRunStatus

[JeromeJu]

Changes

This commit removes status.taskruns and status.runs for
PipelineRunStatus since they have been deprecated. The corresponding usage in
the test cases are replaced with childReferences.

Closes #4954
fixes #6090

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

`pipelinerun.status.taskruns` and `pipelinerun.status.runs` are removed

[tekton-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	89.5%	88.6%	-0.9
pkg/apis/pipeline/v1/pipeline_types.go	97.2%	97.2%	-0.0
pkg/apis/pipeline/v1beta1/pipeline_types.go	96.8%	96.7%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	94.6%	95.7%	1.1
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/cancel.go	90.4%	89.0%	-1.3
pkg/reconciler/pipelinerun/pipelinerun.go	86.6%	87.0%	0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3
pkg/status/status.go	86.8%	86.3%	-0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[jerop]

@JeromeJu please update the PipelineRun status documentation as well - https://github.com/tektoncd/pipeline/blob/main/docs/pipelineruns.md#pipelinerun-status

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[pritidesai]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 88.3% 87.9% -0.5
pkg/reconciler/pipelinerun/pipelinerun.go 87.2% 87.0% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.8% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 96.4% 97.7% 1.3

Thank you @JeromeJu for all the hard work on this 🙏 Since this is one of the last PRs and mainly related to the feature which involves deleting existing code, I request to maintain the existing go coverage, thanks!

[pritidesai]

The changes looks good to me, it will be great if you can improve the code coverage otherwise happy to merge, thanks!

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.3%	87.9%	-0.5
pkg/reconciler/pipelinerun/pipelinerun.go	87.2%	87.0%	-0.2
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.8%	-0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	96.4%	97.7%	1.3

[JeromeJu]

I was wondering if there are any approaches suggested here or is this inevitable? Currently I have tried to add ChildReferences cases to pipelinerun reconciler unit tests as replacement for taskruns and runs status, but that doesn't seem to help with restoring the coverage as I think most of the pipelineRunStatus related codes are still covered.

From the coverage report, there are some other uncovered cases could be added but I don't think they would be suitable to fit in this PR since they are not relevant to PipelineRunStatus 🤔

The changes looks good to me, it will be great if you can improve the code coverage otherwise happy to merge, thanks!

[pritidesai]

thank you @JeromeJu 👍

The test coverage is certainly not a blocker here. Happy to merge and you can follow up improving coverage in a separate PR.

Here are some pointers to add more coverage:

The coverage before and after of pkg/apis/pipeline/v1beta1/pipelinerun_types.go:

The coverage before and after of pkg/reconciler/pipelinerun/pipelinerun.go:

[pritidesai]

Please confirm the beta integration test failure is not a flake and I can merge this, thank you! 🙏

[pritidesai]

/retest

[JeromeJu]

thank you @JeromeJu 👍

The test coverage is certainly not a blocker here. Happy to merge and you can follow up improving coverage in a separate PR.

Here are some pointers to add more coverage:

The coverage before and after of pkg/apis/pipeline/v1beta1/pipelinerun_types.go:

The coverage before and after of pkg/reconciler/pipelinerun/pipelinerun.go:

Thanks @pritidesai for the pointers! I created #6159 and will follow up in a separate PR!

Also confirmed with @XinruZhang offline that the beta integration is an known flake where the network glitches for CI.
/retest

[pritidesai]

thank you @JeromeJu 🙏

/lgtm