Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PipelineRunStatus Reconciler for EmbeddedStatus Switch #5989

Merged
merged 1 commit into from
Jan 18, 2023

Commits on Jan 18, 2023

  1. Fix PipelineRunStatus Reconciler Updates and Tests for EmbeddedStatus…

    … Switch
    
    This commit fixes the updates for reconciling PipelineRunStatus when switching
    the EmbeddedStatus feature flag. It resets the status.runs and status.taskruns
    to nil with minimal EmbeddedStatus and status.childReferences to nil with
    full EmbeddedStatus.
    
    Prior to this change, the childReferences runs and taskruns in pipelineRunStatus
    would not have been reset to nil and could have led to validation error when the feature
    flag is being switched. The following issue could help prevent such bugs in the future:
    Integration tests for changing feature flags tektoncd#5999
    JeromeJu committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    2bb4f14 View commit details
    Browse the repository at this point in the history