Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0091] add KMS libraries #5890

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[TEP-0091] add KMS libraries #5890

merged 1 commit into from
Jan 5, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Dec 19, 2022 •
edited
Loading

Changes

This commit adds kms libraries into trusted resources verifier package, so that we could use kms for verification. Before this commit we only supports loading keys from files.

This is similar to what we have done in Chains

/kind feature

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2022
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review December 19, 2022 19:24
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2022
@Yongxuanzhang Yongxuanzhang changed the title [TEP-0091] add kms libraries [TEP-0091] add KMS libraries Dec 19, 2022
@Yongxuanzhang Yongxuanzhang mentioned this pull request Dec 19, 2022
Closed
15 tasks
@Yongxuanzhang
Copy link
Member Author

tracking issue: #5527

@Yongxuanzhang
Copy link
Member Author

/retest

wlynch
wlynch reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
chuangw6
chuangw6 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@chuangw6 chuangw6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jerop
jerop reviewed Dec 21, 2022
View reviewed changes
pkg/trustedresources/verifier/verifier.go Outdated
Comment on lines 29 to 32
_ "github.com/sigstore/sigstore/pkg/signature/kms/aws" // pull in aws kms libraries
_ "github.com/sigstore/sigstore/pkg/signature/kms/azure" // pull in azure kms libraries
_ "github.com/sigstore/sigstore/pkg/signature/kms/gcp" // pull in gcp kms libraries
_ "github.com/sigstore/sigstore/pkg/signature/kms/hashivault" // pull in hashivault kms libraries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these blank identifiers here for now because the packages are not yet used? if so, why not import the packages in the PR where they are actually used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerop they are imported here for the init of those packages to be executed, to "register" themselves on some other "package" that is/might be used.
For example, this is the same technique used by the k8s credential package helper.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I am usually not a fan of that approach, but oh well, sometimes there is no other way around 🙃 )

Copy link
Member Author

@Yongxuanzhang Yongxuanzhang Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!! @vdemeester.
Sorry I was ooo before and not able to answer this comment. @jerop

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments here aren't very informative, consider removing them or including a one-line comment that we need to execute these packages' init functions for xyz reasons.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2022
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 3, 2023
@dibyom
Copy link
Member

dibyom commented Jan 5, 2023

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuangw6, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
lbernick
lbernick reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: This new dependency is covered under the flexibility section of TEP-0091.

pkg/trustedresources/verifier/verifier.go Outdated
Comment on lines 29 to 32
_ "github.com/sigstore/sigstore/pkg/signature/kms/aws" // pull in aws kms libraries
_ "github.com/sigstore/sigstore/pkg/signature/kms/azure" // pull in azure kms libraries
_ "github.com/sigstore/sigstore/pkg/signature/kms/gcp" // pull in gcp kms libraries
_ "github.com/sigstore/sigstore/pkg/signature/kms/hashivault" // pull in hashivault kms libraries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments here aren't very informative, consider removing them or including a one-line comment that we need to execute these packages' init functions for xyz reasons.

@Yongxuanzhang
[TEP-0091] add kms libraries
73e3289 
This commit adds kms libraries into trusted resources verifier package,
so that we could use kms for verification. Before this commit we only
supports loading keys from files.

Signed-off-by: Yongxuan Zhang [email protected]
@Yongxuanzhang
Copy link
Member Author

Note to reviewers: This new dependency is covered under the flexibility section of TEP-0091.

Thanks! We need to have comment for each line, so I changed the comments as you suggested

@lbernick
Copy link
Member

lbernick commented Jan 5, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@tekton-robot tekton-robot merged commit b27ec73 into tektoncd:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@jerop jerop jerop left review comments

@wlynch wlynch wlynch left review comments

@vdemeester vdemeester vdemeester left review comments

@chuangw6 chuangw6 chuangw6 approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@wlynch wlynch

@lbernick lbernick

@chuangw6 chuangw6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Yongxuanzhang @tekton-robot @dibyom @lbernick @vdemeester @wlynch @jerop @chuangw6