Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0121: Retries - Reconciler Implementation #5844

Merged
merged 1 commit into from
Dec 21, 2022

Commits on Dec 21, 2022

  1. TEP-0121: Reconciler Implementation

    Prior to this commit, `retries` logic for TaskRun is handled by
    Tekton `PipelineRun` reconciler. This commit delegates the retries
    implementation for `TaskRun` to the `TaskRun` reconciler.
    
    The major change is we stopped relying on `len(retriesStatus)` to
    decide if a target `TaskRun` failed or not. Instead, we use status
    `ConditionSuceeded` to gate the completion of a `TaskRun`. Even a
    `TaskRun` failed on one execution, as long as it has remaining
    retries, the TaskRun won't be stored in etcd with its status set
    as `Failed`. Instead, the status will be:
    
    ```yaml
    Type: Succeeded
    Status: Unknown
    Reason: ToBeRetried
    ```
    XinruZhang committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9be9e9a View commit details
    Browse the repository at this point in the history