-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: update pull-request template #4929
.github: update pull-request template #4929
Conversation
The main goal of this change is to make sure that, not editing anything from the template makes the `release-note` check unhappy instead of happy, so that it "gives" feedback that something needs to be updated. Signed-off-by: Vincent Demeester <[email protected]>
/cc @tektoncd/core-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can at least experiment and see if this nudges contributors to add the release notes
/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
Changes
The main goal of this change is to make sure that, not editing
anything from the template makes the
release-note
check unhappyinstead of happy, so that it "gives" feedback that something needs to
be updated.
Signed-off-by: Vincent Demeester [email protected]
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes