Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: update pull-request template #4929

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

vdemeester
Copy link
Member

Changes

The main goal of this change is to make sure that, not editing
anything from the template makes the release-note check unhappy
instead of happy, so that it "gives" feedback that something needs to
be updated.

Signed-off-by: Vincent Demeester [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

The main goal of this change is to make sure that, not editing
anything from the template makes the `release-note` check unhappy
instead of happy, so that it "gives" feedback that something needs to
be updated.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2022
@vdemeester
Copy link
Member Author

/cc @tektoncd/core-maintainers
Not sure if it's the right change but…

@tekton-robot tekton-robot requested a review from a team June 2, 2022 14:47
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can at least experiment and see if this nudges contributors to add the release notes

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@abayer
Copy link
Contributor

abayer commented Jun 3, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 6, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@tekton-robot tekton-robot merged commit 342ed52 into tektoncd:main Jun 6, 2022
@vdemeester vdemeester deleted the github-pr-template-update branch June 7, 2022 07:28
@abayer abayer mentioned this pull request Aug 11, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants