Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only copy output resource to PVC for storage/git output #414

Merged
merged 2 commits into from
Jan 22, 2019

Commits on Jan 21, 2019

  1. Onpy copy output resource to PVC for storage/git output

    At the moment the output_resource module unconditionally adds a
    copy step for every output resource in the taskrun.
    However not every output resource will generate content to be
    copied. Limit the copy to Storage and Git outoputs for now.
    
    This is meant as a hotfix for bug tektoncd#401 until an implementation
    of the image output resource is available via tektoncd#216. Until
    image resource output is implemented, any consumer won't
    have guarantee that the image has been actually built and pushed,
    and won't know the hash of the created image.
    afrittoli committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    8ddbc96 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Move the allowed output resource to a map

    Add a map that defines which output resource produces an output
    that should be copied to the PVC. Add unit tests for it too.
    afrittoli committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    b116f07 View commit details
    Browse the repository at this point in the history