Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fake AWS credentials on controller to workaround aws-sdk bug #4073

Merged
merged 1 commit into from Jul 12, 2021
Merged

Set fake AWS credentials on controller to workaround aws-sdk bug #4073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions config/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
# These phony AWS credentials are here to work around a bug in the aws go sdk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add an issue to track this and mention it in the comment? (either here or in go-containerregistry) 🙏

basically just trying to make sure when someone stumbles on this years from now cuz they need to change it that they know where to go to see what the latest state is (i mean they can always track it through the blame but since this is kind of a hack workaround, it feels like we'd like to maybe pursue a long term solution at some point)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, we should track this in its own parent issue and probably open or identify an aws-sdk-go issue that's at the bottom of this turtle stack.

# that causes extremely long delays in the execution of tasks after the initial
# deployment of the Tekton Pipelines controller.
- name: AWS_ACCESS_KEY_ID
value: foobarbaz
- name: AWS_SECRET_ACCESS_KEY
value: foobarbaz
- name: AWS_DEFAULT_REGION
value: foobarbaz

# If you are changing these names, you will also need to update
# the controller's Role in 200-role.yaml to include the new
# values in the "configmaps" "get" rule.
Expand Down