Remove creds-init image from release/nightly pipelines #3674
Conversation
The creds-init image is no more, so we can remove it from the images that are built during the release (nightly or official). Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
release-note-none
There was a problem hiding this comment.
Thank you!
If we wanted at some point to make a v0.19.x or earlier minor release, we may need the old version of the pipeline, but I think this can be solved by pulling the version of the pipeline from the branch.
If future, we might want to keep tagged version of these into a registry, so we can run the correct version just by changing the bundle version.
/approve
tekton-robot
added
the
approved
|
I am disappointed that my grep-fu did not catch these when I removed the source last week. 😅 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-tekton-pipeline-integration-tests |
Oh... tektoncd/plumbing#675 is really needed 😬 |
|
/test pull-tekton-pipeline-integration-tests |
Changes
The creds-init image is no more, so we can remove it from the images
that are built during the release (nightly or official).
Signed-off-by: Vincent Demeester [email protected]
/cc @sbwsg @afrittoli
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes