Replace variables in Sidecar Script block #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while ago we added Script block support to Sidecars but forgot to perform variable replacement on them. We perform variable replacement on pretty much every other important field in a Sidecar so we should probably also do it in Scripts. This commit applies variables used in Sidecar Script blocks and adds a few tests for it (copied from the existing step_replacements func).
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
ghost
removed
the
|
/kind bug |
pritidesai
reviewed
Oct 2, 2020
| @@ -0,0 +1,131 @@ | |||
| /* | |||
| Copyright 2019 The Tekton Authors | |||
pritidesai
approved these changes
Oct 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A while ago we added Script block support to Sidecars but forgot
to perform variable replacement on them. We perform variable replacement
on pretty much every other important field in a Sidecar so we should
probably also do it in Scripts.
This commit applies variables used in Sidecar Script blocks and adds
a few tests for it (copied from the existing step_replacements func).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes
/kind bug