Accept CloudEvents in any order for CE reconcile test #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
| } | ||
| case <-timer.C: | ||
| if len(expected) != 0 { | ||
| return fmt.Errorf("timed out waiting for %d more events", len(expected)) |
There was a problem hiding this comment.
maybe include the remaining expected events too
fmt.Errorf("timed out waiting for %d more events: %#v", len(expected), expected)
|
/lgtm |
Prior to this commit the test cloud events received during reconcile were required to be emitted in a strict order. We've been seeing some flakes in our unit tests related to this and in #2992 we posited that this might be happening because the cloud events controller emits each event in a separate go routine. We added some extra logging to try and catch the details of the flakes and it does appear that the events are being sent out-of-order. This commit adds a new helper func that allows the expected cloudevents to appear in any order while still failing the test if an unexpected event (or not enough events) are received.
|
/test pull-tekton-pipeline-integration-tests |
afrittoli
reviewed
Oct 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/kind flake /retest |
tekton-robot
added
the
kind/flake
|
/remove-kind flake |
tekton-robot
removed
the
kind/flake
|
/kind flake |
tekton-robot
added
the
kind/flake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2992
Prior to this commit test cloud events received during reconcile were
required to be emitted in a strict order. We've been seeing some flakes in
our unit tests related to this and in
#2992 we posited that this might
be happening because the cloud events controller emits each event in a
separate go routine. We added some extra logging to try and catch the
details of the flakes and it does appear that the events are being sent
out-of-order.
This commit adds a new helper func that allows the expected cloudevents
to appear in any order while still failing the test if an unexpected event
(or not enough events) are received.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes