Use the test context in Reconcile tests #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
The reconcile tests setup a test context along with other test assets using the test.controller module. The context however is not returned as part of the assets, so when we invoke `Reconcile` in reconciler tests we pass a fresh `context.Background()` which does not include the test logger. This causes log lines from taskrun.go and pipelinerun.go to be logged with a different format and with INFO log level instead of the DEBUG one required to troubleshoot test failures. This PR fixes that by adding the context to the test assets, and passing it to `Reconcile`. See tektoncd#3282 (comment) for more context and results with a forced test failure. Follows up tektoncd#3282, works towards tektoncd#2992 Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
use_test_context_in_reconcile
branch
from
da24126
to
d6a58f8
Compare
|
/test pull-tekton-pipeline-integration-tests |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Aha! Nice find. /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The reconcile tests setup a test context along with other test
assets using the test.controller module. The context however is
not returned as part of the assets, so when we invoke
Reconcilein reconciler tests we pass a fresh
context.Background()whichdoes not include the test logger. This causes log lines from
taskrun.go and pipelinerun.go to be logged with a different format
and with INFO log level instead of the DEBUG one required to
troubleshoot test failures.
This PR fixes that by adding the context to the test assets, and
passing it to
Reconcile.See #3282 (comment) for more context and results with a forced test failure.
Follows up #3282, works towards #2992
Signed-off-by: Andrea Frittoli [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
/kind bug
/cc @vdemeester @sbwsg @bobcatfish