Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove release-note block indentation in PR template 🌮 #3269

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Remove release-note block indentation in PR template 🌮 #3269

merged 1 commit into from
Sep 22, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Sep 21, 2020 •
edited
Loading

Changes

Having the indentation on those code block make its more painful for
users to easily write the release note block.

Signed-off-by: Vincent Demeester [email protected]

/cc @tektoncd/core-maintainers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/kind misc

@vdemeester
Remove release-note block indentation in PR template 🌮
56b0f22 
Having the indentation on those code block make its more painful for
users to easily write the release note block.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot requested a review from a team September 21, 2020 15:43
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2020
ghost
ghost approved these changes Sep 21, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2020
@pritidesai
Copy link
Member

Interestingly I scraped through community repo to change this and gave up, its in our own pipeline repo 😱
thanks @vdemeester this will be a huge help and save us some time 👍
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@dibyom
Copy link
Member

dibyom commented Sep 21, 2020

Nice, we should port this to triggers too!

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

2 similar comments
@piyush-garg
Copy link
Contributor

/test pull-tekton-pipeline-unit-tests

@piyush-garg
Copy link
Contributor

/test pull-tekton-pipeline-unit-tests

@piyush-garg
Copy link
Contributor

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@piyush-garg
Copy link
Contributor

/hold cancel

Did to retrigger job

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@bobcatfish
Copy link
Collaborator

yessssss 🙏 🙏 🙏 🙏 🙏

Thank you @vdemeester XD

dibyom added a commit to tektoncd/triggers that referenced this pull request Sep 21, 2020
@dibyom
Un-indent release not blocks in PR template
8bc2dae 
Port of tektoncd/pipeline#3269
tekton-robot pushed a commit to tektoncd/triggers that referenced this pull request Sep 21, 2020
@dibyom @tekton-robot
Un-indent release not blocks in PR template
8900fe5 
Port of tektoncd/pipeline#3269
@bobcatfish
Copy link
Collaborator

/retest

@bobcatfish bobcatfish mentioned this pull request Sep 21, 2020
Closed
@vdemeester
Copy link
Member Author

So the current job is sucessfull (https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/3269/pull-tekton-pipeline-unit-tests/1308069547818881025/)
/test pull-tekton-pipeline-unit-tests

@vdemeester
Copy link
Member Author

/lgtm cancel

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@vdemeester
Copy link
Member Author

(temporarly removing them from the merge queue to unlock some)

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

3 similar comments
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Sep 22, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Sep 22, 2020
@tekton-robot tekton-robot merged commit 078e7c8 into tektoncd:master Sep 22, 2020
@vdemeester vdemeester deleted the pr-template-deindent branch September 22, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@pritidesai pritidesai

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vdemeester @tekton-robot @pritidesai @piyush-garg @dibyom @bobcatfish