Clean up dag_test.go #3230
Merged
Clean up dag_test.go #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
popcor255
reviewed
Sep 15, 2020
test/dag_test.go
Outdated
Comment on lines
223
to
236
| if !strings.HasPrefix(taskRuns[0].Name, "dag-pipeline-run-pipeline-task-1") { | ||
| t.Errorf("Expected first task to execute first, but %q was first", taskRuns[0].Name) | ||
| } | ||
| if !strings.HasPrefix(times[1].name, "dag-pipeline-run-pipeline-task-2") { | ||
| t.Errorf("Expected parallel tasks to run second & third, but %q was second", times[1].name) | ||
| if !strings.HasPrefix(taskRuns[1].Name, "dag-pipeline-run-pipeline-task-2") { | ||
| t.Errorf("Expected parallel tasks to run second & third, but %q was second", taskRuns[1].Name) | ||
| } | ||
| if !strings.HasPrefix(times[2].name, "dag-pipeline-run-pipeline-task-2") { | ||
| t.Errorf("Expected parallel tasks to run second & third, but %q was third", times[2].name) | ||
| if !strings.HasPrefix(taskRuns[2].Name, "dag-pipeline-run-pipeline-task-2") { | ||
| t.Errorf("Expected parallel tasks to run second & third, but %q was third", taskRuns[2].Name) | ||
| } | ||
| if !strings.HasPrefix(times[3].name, "dag-pipeline-run-pipeline-task-3") { | ||
| t.Errorf("Expected third task to execute third, but %q was third", times[3].name) | ||
| if !strings.HasPrefix(taskRuns[3].Name, "dag-pipeline-run-pipeline-task-3") { | ||
| t.Errorf("Expected third task to execute third, but %q was third", taskRuns[3].Name) | ||
| } | ||
| if !strings.HasPrefix(times[4].name, "dag-pipeline-run-pipeline-task-4") { | ||
| t.Errorf("Expected fourth task to execute fourth, but %q was fourth", times[4].name) | ||
| if !strings.HasPrefix(taskRuns[4].Name, "dag-pipeline-run-pipeline-task-4") { | ||
| t.Errorf("Expected fourth task to execute fourth, but %q was fourth", taskRuns[4].Name) |
There was a problem hiding this comment.
Is dag-pipeline-run-pipeline-task-2 supposed to be there twice on line 226 and 229?
Also, can we put this in a loop?
There was a problem hiding this comment.
oh, I see what this is doing. 🤦 nvm.
There was a problem hiding this comment.
Yeah it confused me too, and even after I "got" it I had a moment of panic when I read your comment that this test wasn't correct. I think we could use better names :)
|
/lgtm |
- don't use test builders - use script mode instead of command+args - sort start times using sort.Slice - compare parallel task start times using math.Abs in case s1 starts >5s before s2 -- only the other case was checked before - then copy test/dag_test.go -> test/v1alpha1/dag_test.go and fix incompatibilities
bobcatfish
reviewed
Sep 15, 2020
| it := taskRuns[i].Status.StartTime.Time | ||
| jt := taskRuns[j].Status.StartTime.Time | ||
| return it.Before(jt) | ||
| }) |
| for i, wp := range wantPrefixes { | ||
| if !strings.HasPrefix(taskRuns[i].Name, wp) { | ||
| t.Errorf("Expected task %q to execute first, but %q was first", wp, taskRuns[0].Name) | ||
| } |
| s2 := taskRuns[2].Status.StartTime.Time | ||
| absDiff := time.Duration(math.Abs(float64(s2.Sub(s1)))) | ||
| if absDiff > (time.Second * 5) { | ||
| t.Errorf("Expected parallel tasks to execute more or less at the same time, but they were %v apart", absDiff) |
There was a problem hiding this comment.
well this test is a lot easier to understand now :D
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
/kind cleanup
/area testing
#3178