-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit cleaning up the Affinity Assistant if disabled #3214
Omit cleaning up the Affinity Assistant if disabled #3214
Conversation
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit introduces a check if the Assistant is disabled, and only cleanup the Assistant if disabled
195f421
to
84574d0
Compare
The following is the coverage report on the affected files.
|
I also added a unit test to check this property. |
Instead of checking the error message Sorry if this is already discussed somewhere else 🙏 |
thanks @jlpettersson |
Changes
This commit introduces a check if the Assistant is
disabled, and only cleanup the Assistant if disabled
Related to #3212
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes