-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nop-image to release instructions #3186
Conversation
In tektoncd#3025 the nop-image was added to our release pipeline, this commit updates our README to include an example that sets it. Also removed the reference to resources.yaml from the instructions b/c imo opening that file and modifying it is more confusing than helpful; feels like it makes more sense to create a new PipelineResource instance without bothering with that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Suggest updating the release cheat sheet as well: https://github.com/tektoncd/pipeline/blob/master/tekton/release-cheat-sheet.md I can do that in a separate PR. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Thanks @sbwsg ! ps can we delete the other README and replace it with the cheatsheet? i didnt know there was one! |
I was hesitant to do that originally because of the extra information contained in the README. But I'd definitely be open to it. I'll add something to the productivity WG agenda for next week. |
/test pull-tekton-pipeline-integration-tests |
Changes
In #3025 the nop-image was added to our release pipeline, this commit
updates our README to include an example that sets it.
Also removed the reference to resources.yaml from the instructions b/c
imo opening that file and modifying it is more confusing than helpful;
feels like it makes more sense to create a new PipelineResource instance
without bothering with that file.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes