Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nop-image to release instructions #3186

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

bobcatfish
Copy link
Collaborator

Changes

In #3025 the nop-image was added to our release pipeline, this commit
updates our README to include an example that sets it.

Also removed the reference to resources.yaml from the instructions b/c
imo opening that file and modifying it is more confusing than helpful;
feels like it makes more sense to create a new PipelineResource instance
without bothering with that file.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

In tektoncd#3025 the nop-image was added to our release pipeline, this commit
updates our README to include an example that sets it.

Also removed the reference to resources.yaml from the instructions b/c
imo opening that file and modifying it is more confusing than helpful;
feels like it makes more sense to create a new PipelineResource instance
without bothering with that file.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 9, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2020
@bobcatfish bobcatfish added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 9, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

Suggest updating the release cheat sheet as well: https://github.com/tektoncd/pipeline/blob/master/tekton/release-cheat-sheet.md

I can do that in a separate PR.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibyom
Copy link
Member

dibyom commented Sep 11, 2020

/retest

@bobcatfish
Copy link
Collaborator Author

Thanks @sbwsg ! ps can we delete the other README and replace it with the cheatsheet? i didnt know there was one!

@ghost
Copy link

ghost commented Sep 11, 2020

can we delete the other README and replace it with the cheatsheet?

I was hesitant to do that originally because of the extra information contained in the README. But I'd definitely be open to it. I'll add something to the productivity WG agenda for next week.

@vdemeester
Copy link
Member

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit 994a66c into tektoncd:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants