Add results path variable to results docs #3144
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
bobcatfish
added
the
kind/documentation
|
/lgtm |
|
/test pull-tekton-pipeline-unit-tests |
1 similar comment
|
/test pull-tekton-pipeline-unit-tests |
|
/test pull-tekton-pipeline-unit-tests This one looks stuck.. |
|
/retest |
|
/lgtm cancel |
|
/test pull-tekton-pipeline-unit-tests |
|
@bobcatfish can you rebase/force-push to force the job ? (I unlgtm to unblock the merge queue) |
|
/lgtm |
|
/test pull-tekton-pipeline-unit-tests |
|
well that's strange! |
I didn't realize this variable existed until @chhsia0 used it in tektoncd/community#182 All this time ive been hardcoding this path XD hoping to help some other folks realize this is possible as well.
bobcatfish
force-pushed
the
results_path
branch
from
73af124
to
383e011
Compare
|
Hopefully that'll do it - gonna need another lgtm if you get a chance @vdemeester @dlorenc @pritidesai @sbwsg |
|
/lgtm |
Changes
I didn't realize this variable existed until @chhsia0 used it in
tektoncd/community#182
All this time ive been hardcoding this path XD hoping to help some other
folks realize this is possible as well.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes