-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended documentation about PersistentVolumes within a PipelineRun #2912
Conversation
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
This PR cannot be merged: expecting exactly one kind/ label Available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for this, it's much clearer to me now how the volume configuration and affinity assistant tie together. I left a bunch of language style/nit comments but nothing that is blocking.
There are many things to think about when using PersistentVolumes within a PipelineRun. We have introduced the Affinity Assistant to avoid them. This documentation intend to better describe those problems and configurations so that an end-user can do better choice, e.g. when disabling the Affinity Assistant. /kind documentation
56dcb92
to
b33e444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for adding this @jlpettersson !!! ❤️ |
Changes
There are many things to think about when using PersistentVolumes within a PipelineRun.
We have introduced the Affinity Assistant to avoid them. This documentation intend to better
describe those problems and configurations so that an end-user can do better choice,
e.g. when disabling the Affinity Assistant.
This is things that have been discussed in previous PRs, e.g. #2630 (comment) and #2885 (comment)
/kind documentation
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes