Write command to fetch logs for a failed step in a new line

[waveywaves]

Changes

It should be possible to copy/paste in one go
the command to fetch a failed test logs from
the status of a taskrun.
However, this is not possible as long, single-line
strings (i.e. does not contain "\n") are marshalled,
the yaml emitter forces line breaks at 80 characters.
Due to this the command is being divided into two,
which depriciates the user experience.

fixes #2221

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

[waveywaves]

/assign @sbwsg
cc @afrittoli

[waveywaves]

/test pull-tekton-pipeline-build-tests

[waveywaves]

/test pull-tekton-pipeline-build-tests

[ghost]

Hey, could we do more with the commit message and PR description here? We typically try to include a lot more information than exists right now. From our guidelines:

All commit messages should follow these best practices, specifically:

Start with a subject line
Contain a body that explains why you're making the change you're making
Reference an issue number one exists, closing it if applicable (with text such as "Fixes #245" or "Closes #111")

Aim for 2 paragraphs in the body. Not sure what to put? Include:

What is the problem being solved?
Why is this the best approach?
What other approaches did you consider?
What side effects will this approach have?
What future work remains to be done?

Here is an example formatting for this commit:

Write command to fetch logs for a failed step in a new line

When a command fails Tekton includes a message with the kubectl command to check logs from the failing Task containers.  Unfortunately this message is limited in length by Tekton's YAML library and, for long container names, will be forced to wrap to a new line.  Copy-pasting the kubectl logs command will then not work.

This commit alleviates the problem by inserting a newline just before the kubectl logs command.  This will give some more characters for long container names to appear in a single line on the console.

[waveywaves]

@afrittoli @sbwsg I am having a hard time understanding what is wrong with the integration tests. Can you help out ?

[ghost]

I0404 18:27:31.260] panic: test timed out after 20m0s

Looks like a timeout. Possibly unrelated to the code changes here. Retrying to see if it reproduces again.

/test pull-tekton-pipeline-integration-tests

[waveywaves]

/test pull-tekton-pipeline-integration-tests

[waveywaves]

@sbwsg It was a flake as you said

[ghost]

Would be great to see a comment explaining the change but otherwise this looks good to me. Thanks!

/approve

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment