Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipRootUserTests flag required by PR #1563 #2269

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Add skipRootUserTests flag required by PR #1563 #2269

merged 1 commit into from
Mar 24, 2020

Conversation

fgiloux
Copy link
Contributor

@fgiloux fgiloux commented Mar 23, 2020

PR #1563 adds logic to skip TestKanikoTaskRun test when a flag is set as it requires to run containers with root user.
The registration of the flag was however missing. This aims to fix it.

Changes

flag added to TestKanikoTaskRun
test/README.md amended to have the flag documented

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2020
@tekton-robot
Copy link
Collaborator

Hi @fgiloux. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2020
@fgiloux
Copy link
Contributor Author

fgiloux commented Mar 23, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit and removed cla: no labels Mar 23, 2020
@dibyom
Copy link
Member

dibyom commented Mar 23, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2020
@fgiloux
Copy link
Contributor Author

fgiloux commented Mar 24, 2020

/retest

@vdemeester
Copy link
Member

@fgiloux seems like gofmt ain't happy 😉

I0323 22:34:19.383] -------------------------------------------
I0323 22:34:19.383] ---- Checking go code style with gofmt ----
I0323 22:34:19.383] -------------------------------------------
I0323 22:34:20.317] diff -u test/kaniko_task_test.go.orig test/kaniko_task_test.go
I0323 22:34:20.318] --- test/kaniko_task_test.go.orig	2020-03-23 22:34:20.208809722 +0000
I0323 22:34:20.318] +++ test/kaniko_task_test.go	2020-03-23 22:34:20.208809722 +0000
I0323 22:34:20.318] @@ -47,7 +47,7 @@
I0323 22:34:20.318]  )
I0323 22:34:20.318]  
I0323 22:34:20.319]  func init() {
I0323 22:34:20.319] -  flag.StringVar(&skipRootUserTests, "skipRootUserTests", "false", "Skip tests that require root user")
I0323 22:34:20.319] +	flag.StringVar(&skipRootUserTests, "skipRootUserTests", "false", "Skip tests that require root user")
I0323 22:34:20.319]  }

gofmt -s -w test/kaniko_task_test.go to fix it 👼

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
PR #1563 adds logic to skip TestKanikoTaskRun test when a flag is set as it requires to run containers with root user.
The registration of the flag was however missing. This aims to fix it.
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit a65caec into tektoncd:master Mar 24, 2020
@fgiloux
Copy link
Contributor Author

fgiloux commented Mar 24, 2020

Thanks vdemeester for the hint and sorry for forgetting to run go fmt

@afrittoli afrittoli added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants