Add skipRootUserTests flag required by PR #1563

[fgiloux]

PR #1563 adds logic to skip TestKanikoTaskRun test when a flag is set as it requires to run containers with root user.
The registration of the flag was however missing. This aims to fix it.

Changes

flag added to TestKanikoTaskRun
test/README.md amended to have the flag documented

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[tekton-robot]

Hi @fgiloux. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fgiloux]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[dibyom]

/ok-to-test

[fgiloux]

/retest

[vdemeester]

@fgiloux seems like gofmt ain't happy 😉

I0323 22:34:19.383] -------------------------------------------
I0323 22:34:19.383] ---- Checking go code style with gofmt ----
I0323 22:34:19.383] -------------------------------------------
I0323 22:34:20.317] diff -u test/kaniko_task_test.go.orig test/kaniko_task_test.go
I0323 22:34:20.318] --- test/kaniko_task_test.go.orig	2020-03-23 22:34:20.208809722 +0000
I0323 22:34:20.318] +++ test/kaniko_task_test.go	2020-03-23 22:34:20.208809722 +0000
I0323 22:34:20.318] @@ -47,7 +47,7 @@
I0323 22:34:20.318]  )
I0323 22:34:20.318]  
I0323 22:34:20.319]  func init() {
I0323 22:34:20.319] -  flag.StringVar(&skipRootUserTests, "skipRootUserTests", "false", "Skip tests that require root user")
I0323 22:34:20.319] +	flag.StringVar(&skipRootUserTests, "skipRootUserTests", "false", "Skip tests that require root user")
I0323 22:34:20.319]  }

gofmt -s -w test/kaniko_task_test.go to fix it 👼

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fgiloux]

Thanks vdemeester for the hint and sorry for forgetting to run go fmt