Improve test coverage on reconcile taskrun #2232
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
| func TestReconcileTaskResourceResolutionAndValidation(t *testing.T) { | ||
| for _, c := range []struct { | ||
| desc string | ||
| d test.Data |
There was a problem hiding this comment.
could we add a field here like wantFailedReason which could be set to ReasonFailedValidation or ReasonFailedResolution? Then in the comparison we can exactly check if the test case failed for this exact reason!
There was a problem hiding this comment.
could we add a field here like wantFailedReason which could be set to ReasonFailedValidation or ReasonFailedResolution? Then in the comparison we can exactly check if the test case failed for this exact reason!
Thanks! it's very nice and make sense.
I fixed it 👍
Signed-off-by: 16yuki0702 <[email protected]>
16yuki0702
force-pushed
the
adding_reconcile_testcase
branch
from
6c4056b to
3eb9b24
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
Changes
Adding test cases for resource resolution and validating resource.
This PR has no effect on features.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes