SetDefaults for embedded specs (Pipeline, Task) 🥄

[vdemeester]

Changes

Embedded TaskSpec and PipelineSpec were not being set defaults when
the resource embedding it was. This fixes that.

Signed-off-by: Vincent Demeester [email protected]

/cc @sbwsg @bobcatfish
Fix #2157

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Fix defaults not being applied for embedded Pipeline(s) and Task(s)

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_defaults.go	100.0%	93.8%	-6.2
pkg/apis/pipeline/v1beta1/pipeline_defaults.go	0.0%	33.3%	33.3

[vdemeester]

Will need to get cherry-pick in a 0.11 branch. I feel we need a label for this 👼

[vdemeester]

/test pull-tekton-pipeline-integration-tests

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pritidesai]

/lgtm

Thanks @vdemeester 👍