-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioned links to docs and examples for v0.9.0 #1660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Waiting for the tag to be created (and release done 👼) ?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I was hoping to merge this first and do the release right afterwards. |
@afrittoli make sense 👼 |
I think this was worth a shot but i just got pinged by someone who tried to follow the docs link for 0.9.0 and was confused why it was broken, so I think in the future it might be better to merge this after the release and tag are created? |
Or make sure we do it simultaneously! (With a Tekton Task maybe? :D) |
Waw some people are quite quick then 🤔 To @afrittoli's point, "That means that for a few minutes those links will be broken, but in future, if someone checks out the tag, the link to the docs is there in the README.", I think this is worth merging before the release (aka having this commit in the release). Maybe we need to "automate" the commit in the release pipeline 👼 |
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes