Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioned links to docs and examples for v0.9.0 #1660

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

afrittoli
Copy link
Member

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@tekton-robot tekton-robot requested review from imjasonh and a user December 2, 2019 13:45
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Dec 2, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Waiting for the tag to be created (and release done 👼) ?

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 2, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@afrittoli
Copy link
Member Author

I was hoping to merge this first and do the release right afterwards.
That means that for a few minutes those links will be broken, but in future, if someone checks out the tag, the link to the docs is there in the README.

@vdemeester
Copy link
Member

@afrittoli make sense 👼
/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@tekton-robot tekton-robot merged commit 5e59ba4 into tektoncd:master Dec 2, 2019
@bobcatfish
Copy link
Collaborator

I think this was worth a shot but i just got pinged by someone who tried to follow the docs link for 0.9.0 and was confused why it was broken, so I think in the future it might be better to merge this after the release and tag are created?

@bobcatfish
Copy link
Collaborator

Or make sure we do it simultaneously! (With a Tekton Task maybe? :D)

@vdemeester
Copy link
Member

I think this was worth a shot but i just got pinged by someone who tried to follow the docs link for 0.9.0 and was confused why it was broken, so I think in the future it might be better to merge this after the release and tag are created?

Waw some people are quite quick then 🤔 To @afrittoli's point, "That means that for a few minutes those links will be broken, but in future, if someone checks out the tag, the link to the docs is there in the README.", I think this is worth merging before the release (aka having this commit in the release). Maybe we need to "automate" the commit in the release pipeline 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants