Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Adding "volume" aka "workspace" declaration to Tasks #1508

Closed
wants to merge 1 commit into from

Conversation

bobcatfish
Copy link
Collaborator

Changes

So far just docs and examples for declaring volumes in a Task via the
"workspace" field and binding to them at runtime. This is midway between
@skaegi's proposal b/c it allows the user to bring their own PVC but
isn't the full cadillac version because it does not include volume
devices.

@skaegi what do you think so far?

(Will eventually fix #1438)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

TBD

So far just docs and examples for declaring volumes in a Task via the
"workspace" field and binding to them at runtime. This is midway between
@skaegi's proposal b/c it allows the user to bring their own PVC but
isn't the full cadillac version because it does not include volume
devices.

Will eventually fix  tektoncd#1438
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2019
@tekton-robot tekton-robot requested review from abayer and a user October 31, 2019 20:55
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobcatfish
You can assign the PR to them by writing /assign @bobcatfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2019
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 31, 2019
@tekton-robot
Copy link
Collaborator

@bobcatfish: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-pipeline-integration-tests fdacaf2 link /test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bobcatfish
Copy link
Collaborator Author

Got some great feedback from @skaegi , gonna close this for now and open a new PR with some updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for a "volume resource"-like Task.spec field
3 participants