Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure required PVC is created in reconciler test 👶 #1482

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Make sure required PVC is created in reconciler test 👶 #1482

merged 1 commit into from
Oct 31, 2019

Commits on Oct 25, 2019

  1. Make sure required PVC is created in reconciler test 👶 

    When I was working on tektoncd#1417 (which added the ability to create PVCs for
the Volume Resource and has since been abandoned) I was surprised to
realize that the reconciler test for the PipelineRun controller doesn't
verify that the PVC has been created. It does make sure its attached and
this is covered by the end to end tests that wouldn't work without it,
but I thought it made sense to test here too since we can.
    @bobcatfish
    bobcatfish committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    c1ebc76 View commit details
    Browse the repository at this point in the history