-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for release-postprocessing #1457
Add support for release-postprocessing #1457
Conversation
b1be433
to
115892c
Compare
Some minor nits but otherwise |
115892c
to
937326e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Add a cloud event pipeline resource to the publish-tekton-pipelines Task. This can be used to trigger post-processing services like log collection and automatic post release testing. Add a resource to the pipeline-release and to the pipeline-release-nightly-triggers pipelines to match the Task one.
937326e
to
20d48e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-integration-tests |
Add a cloud event pipeline resource to the publish-tekton-pipelines
Task. This can be used to trigger post-processing services like
log collection and automatic post release testing.
Add a resource to the pipeline-release and to the
pipeline-release-nightly-triggers pipelines to match the Task one.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes