Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow entrypoint binary to wait for multiple files #1430

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

imjasonh
Copy link
Member

Changes

Enables the entrypoint binary to be passed multiple comma-separated paths to its -wait_file flag. The binary will wait for all of those paths to exist before proceeding to execute the command.

This is not exposed in the TaskRun API (nor is it expected to be), and the change is fully backward-compatible for existing users of the entrypoint image.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

entrypoint image allows multiple comma-separated values for the -wait_file flag

@tekton-robot tekton-robot requested review from a user and vdemeester October 15, 2019 17:34
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 15, 2019
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2019
@imjasonh
Copy link
Member Author

imjasonh commented Oct 15, 2019

/assign sbwsg

@ghost
Copy link

ghost commented Oct 15, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Oct 15, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@ghost
Copy link

ghost commented Oct 15, 2019

/test pull-tekton-pipeline-integration-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@tekton-robot tekton-robot merged commit d856958 into tektoncd:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants