Only compare ImageID suffix in TestTaskRunStatus test #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
googlebot
added
the
cla: yes
chmouel
force-pushed
the
fix-TestTaskRunStatus-on-other-clusters
branch
from
b3b92b9
to
306ccac
Compare
tekton-robot
added
size/XS
On some systems (i.e: OpenShift) we are getting a different prefix than docker-pullable:// as docker.io/library instead, Let's ignore that prefix and only compare the suffix of the fqImageName Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
fix-TestTaskRunStatus-on-other-clusters
branch
from
306ccac
to
cce99c4
Compare
|
/test pull-tekton-pipeline-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experience a weird issue with the TestTaskRunStatus test on OpenShift (v4.x based on k8 1.13+). The ImageID are prefixed there with a docker.io/library instead of what is shown on k8 docker-pullable://
I will follow-up with the OpenShift people but in the meantime let's only compare the ImageID suffix which should make the test as robust as what we had before.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: