-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1211 - Remove reference to yqArg in pipeline tutorial #1212
Conversation
In the source yaml https://github.com/GoogleContainerTools/skaffold/blob/master/examples/microservices/leeroy-web/kubernetes/deployment.yaml the yaml file changed and removed the first yaml doc for service. this change makes the tutorial fail. removing reference to yqArg since deployment.yaml has only one document now.
Hi @moficodes. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Oh dang, that's unfortunate. I wonder if we should create our own demo application to use in examples instead. /ok-to-test |
Whoops thanks for catching that @moficodes ! It looks like we ran into this in our pipeline/examples/pipelineruns/pipelinerun.yaml Lines 39 to 49 in 5638925
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc, moficodes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In the source yaml https://github.com/GoogleContainerTools/skaffold/blob/master/examples/microservices/leeroy-web/kubernetes/deployment.yaml the yaml file changed and removed the first yaml doc for service.
this change makes the tutorial fail. removing reference to yqArg since deployment.yaml has only one document now.
Changes
docs/tutorial.md
Removed reference to
yqArg
in pipeline tutorialFixes issue #1211
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task and TaskRun to build and release this image
Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes