Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a link - display name #7190

Closed
pritidesai opened this issue Oct 9, 2023 · 4 comments · Fixed by #7205
Closed

fix a link - display name #7190

pritidesai opened this issue Oct 9, 2023 · 4 comments · Fixed by #7205
Assignees
@vavrajosef
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. Hacktoberfest Categorizes issue as one for Hacktoberfest 2021 help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@pritidesai
Copy link
Member

pipelines.md has a incorrect link in a section where with optional configruation.

displayName in multiple places should point to https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#specifying-a-display-name instead it is pointing to https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#adding-tasks-to-the-pipeline and https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#adding-finally-to-the-pipeline.

optional:
  tasks:
    displayName

optional:
  finally:
    displayName:

/kind bug
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 9, 2023
@pritidesai pritidesai added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. Hacktoberfest Categorizes issue as one for Hacktoberfest 2021 labels Oct 9, 2023
@pranav-jadhav
Copy link

Please assign me this issue

@chengjoey
Copy link
Member

Please assign me this issue

hi @pranav-jadhav , you can comment /assign it should assign yourself to the issue (it just needs you to have a comment on the issue)

/assign @pranav-jadhav

@pranav-jadhav pranav-jadhav removed their assignment Oct 10, 2023
@vavrajosef
Copy link
Contributor

Hi, I think I can fix this

@vavrajosef
Copy link
Contributor

/assign @vavrajosef

vavrajosef added a commit to vavrajosef/pipeline that referenced this issue Oct 11, 2023
@vavrajosef
tektoncd#7190 display name link fixed in pipelines.md
9573f81
@vavrajosef vavrajosef mentioned this issue Oct 11, 2023
Merged
7 tasks
tekton-robot pushed a commit that referenced this issue Oct 12, 2023
@vavrajosef @tekton-robot
#7190 display name link fixed in pipelines.md
e950a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vavrajosef vavrajosef

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. Hacktoberfest Categorizes issue as one for Hacktoberfest 2021 help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#7190 display name link fixed in pipelines.md vavrajosef/pipeline
5 participants
@pritidesai @vavrajosef @chengjoey @tekton-robot @pranav-jadhav