Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote TEP-0029 - Isolated Step and Sidecar Workspaces #6109

Closed
pritidesai opened this issue Feb 3, 2023 · 6 comments · Fixed by #6922
Closed

Promote TEP-0029 - Isolated Step and Sidecar Workspaces #6109

pritidesai opened this issue Feb 3, 2023 · 6 comments · Fixed by #6922
Assignees
@afrittoli
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Pipelines v0.50 (...

Comments

@pritidesai
Copy link
Member

pritidesai commented Feb 3, 2023 •
edited
Loading

Feature looking for Promotion

TEP-0029 implemented an alpha feature to support isolation of workspaces to only those steps and sidecars that require access to them. This feature request is created to keep track of work items and any outstanding issues before this feature can be promoted to beta.

Current Feature Version

enable-api-fields: alpha

Raise Feature Version

enable-api-fields: beta

Pipeline Release

Tekton Pipelines 0.24.0

Issues Reported by the Users

None

Usage in Dogfooding Cluster

None

Examples/Tests
@pritidesai pritidesai added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 3, 2023
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2023
@jerop
Copy link
Member

jerop commented May 4, 2023

related issue - #6604

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2023
@jerop jerop mentioned this issue May 4, 2023
Closed
@jerop jerop added this to the Pipelines v0.49 milestone May 4, 2023
@lbernick lbernick mentioned this issue May 8, 2023
Closed
@JeromeJu
Copy link
Member

JeromeJu commented Jun 13, 2023 •
edited
Loading

pipeline WG:

  • no end user cases, maybe we could lower the priority of this
  • move to v0.50

@afrittoli
Copy link
Member

/cc @afrittoli

@afrittoli afrittoli self-assigned this Jul 12, 2023
@afrittoli afrittoli removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 12, 2023
@afrittoli
Copy link
Member

I started looking into this.
The question I have is how to deal with the v1beta1 API.
Until TEP-0138 is implemented, the v1beta1 API should get beta features on by default, so I think that's what I should implement here for consistency. @lbernick @JeromeJu @pritidesai @vdemeester wdyt?

afrittoli added a commit to afrittoli/pipeline that referenced this issue Jul 12, 2023
@afrittoli
[TEP-0029] Isolated steps and sidecar workspaces to beta
2057c67 
This feature has been implemented in Tekton Pipelines v0.24.0.

Isolated workspaces gives our user an option for improved
security, which is why it's important to work towards making
it available to our users by default.

No outstanding issue exists for this feature, except for the
proposal to promote it to beta.

Fixes tektoncd#6109

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli mentioned this issue Jul 12, 2023
Merged
7 tasks
@lbernick
Copy link
Member

I agree; we should have consistency with our existing beta features (resolvers, object params etc).

afrittoli added a commit to afrittoli/pipeline that referenced this issue Jul 13, 2023
@afrittoli
[TEP-0029] Isolated steps and sidecar workspaces to beta
581f32c 
This feature has been implemented in Tekton Pipelines v0.24.0.

Isolated workspaces gives our user an option for improved
security, which is why it's important to work towards making
it available to our users by default.

No outstanding issue exists for this feature, except for the
proposal to promote it to beta.

Fixes tektoncd#6109

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jul 13, 2023
@afrittoli
[TEP-0029] Isolated steps and sidecar workspaces to beta
11e5a7e 
This feature has been implemented in Tekton Pipelines v0.24.0.

Isolated workspaces gives our user an option for improved
security, which is why it's important to work towards making
it available to our users by default.

No outstanding issue exists for this feature, except for the
proposal to promote it to beta.

Fixes tektoncd#6109

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jul 20, 2023
@afrittoli
[TEP-0029] Isolated steps and sidecar workspaces to beta
6c0b284 
This feature has been implemented in Tekton Pipelines v0.24.0.

Isolated workspaces gives our user an option for improved
security, which is why it's important to work towards making
it available to our users by default.

No outstanding issue exists for this feature, except for the
proposal to promote it to beta.

This feature requires the api-features-flag to be set to beta
even when using v1beta1, to avoid running into the issues with
v1/v1beta conversion described in TEP-0138.
Since this feature has been in alpha until now, this is not
a breaking changes, and it's specified in the docs that this
feature requires the flag to be set when using v1beta1.

Fixes tektoncd#6109

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/pipeline that referenced this issue Jul 21, 2023
@afrittoli
[TEP-0029] Isolated steps and sidecar workspaces to beta
a90d610 
This feature has been implemented in Tekton Pipelines v0.24.0.

Isolated workspaces gives our user an option for improved
security, which is why it's important to work towards making
it available to our users by default.

No outstanding issue exists for this feature, except for the
proposal to promote it to beta.

This feature requires the api-features-flag to be set to beta
even when using v1beta1, to avoid running into the issues with
v1/v1beta conversion described in TEP-0138.
Since this feature has been in alpha until now, this is not
a breaking changes, and it's specified in the docs that this
feature requires the flag to be set when using v1beta1.

Note that this feature was gated both at validation as well
as in the reconciler code, which is not how other API driven
features are gated. I removed the reconciler code validation
to be consistent with the other features.

Fixes tektoncd#6109

Signed-off-by: Andrea Frittoli <[email protected]>
tekton-robot pushed a commit that referenced this issue Jul 21, 2023
@afrittoli @tekton-robot
[TEP-0029] Isolated steps and sidecar workspaces to beta
1871c30 
This feature has been implemented in Tekton Pipelines v0.24.0.

Isolated workspaces gives our user an option for improved
security, which is why it's important to work towards making
it available to our users by default.

No outstanding issue exists for this feature, except for the
proposal to promote it to beta.

This feature requires the api-features-flag to be set to beta
even when using v1beta1, to avoid running into the issues with
v1/v1beta conversion described in TEP-0138.
Since this feature has been in alpha until now, this is not
a breaking changes, and it's specified in the docs that this
feature requires the flag to be set when using v1beta1.

Note that this feature was gated both at validation as well
as in the reconciler code, which is not how other API driven
features are gated. I removed the reconciler code validation
to be consistent with the other features.

Fixes #6109

Signed-off-by: Andrea Frittoli <[email protected]>
@dibyom dibyom mentioned this issue Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afrittoli afrittoli

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Pipelines v0.50 (LTS)
Development

Successfully merging a pull request may close this issue.

[TEP-0029] Isolated steps and sidecar workspaces to beta afrittoli/pipeline
6 participants
@pritidesai @afrittoli @jerop @lbernick @JeromeJu @tekton-robot