Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config-trusted-resources when VerificationPolicy is supported #5852

Closed
Yongxuanzhang opened this issue Dec 8, 2022 · 3 comments · Fixed by #6305
Closed

Deprecate config-trusted-resources when VerificationPolicy is supported #5852

Yongxuanzhang opened this issue Dec 8, 2022 · 3 comments · Fixed by #6305
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API

Comments

@Yongxuanzhang
Copy link
Member

config-trusted-resources is introduced for trusted resources to store public key reference, the feature will be fully covered by VerificationPolicy and should be deprecated in future releases.

/kind api-change

@tekton-robot tekton-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 8, 2022
@Yongxuanzhang
Copy link
Member Author

/assign

@jerop jerop added this to the Pipelines v0.46 milestone Feb 16, 2023
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 6, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it.

Closes tektoncd#5852

Signed-off-by: Yongxuan Zhang [email protected]
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 6, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it.

Closes tektoncd#5852

Signed-off-by: Yongxuan Zhang [email protected]
@lbernick
Copy link
Member

lbernick commented Mar 7, 2023

Note: Trusted resources are currently in alpha, so removing config-trusted-resources is allowed by our deprecation policy with one release worth of warning. This configmap was marked as deprecated in release v0.45.0.

@Yongxuanzhang
Copy link
Member Author

Note: Trusted resources are currently in alpha, so removing config-trusted-resources is allowed by our deprecation policy with one release worth of warning. This configmap was marked as deprecated in release v0.45.0.

Thank you!

Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 7, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it.

Closes tektoncd#5852

Signed-off-by: Yongxuan Zhang [email protected]
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 7, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it. Trusted resources is
alpha feature so the configmap can be deprecated with one release
notice.

Closes tektoncd#5852

Signed-off-by: Yongxuan Zhang [email protected]
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 8, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it. Trusted resources is
alpha feature so the configmap can be deprecated with one release
notice.

Closes tektoncd#5852

Signed-off-by: Yongxuan Zhang [email protected]
tekton-robot pushed a commit that referenced this issue Mar 8, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it. Trusted resources is
alpha feature so the configmap can be deprecated with one release
notice.

Closes #5852

Signed-off-by: Yongxuan Zhang [email protected]
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Mar 8, 2023
EmmaMunley pushed a commit to EmmaMunley/pipeline that referenced this issue Mar 9, 2023
This commit removes trusted-resources-config. The deprecation is
announced in release v0.45. The reason of removing is that
trusted-resources-config is used to store public keys for verificaiton
but Verification Policy has already covered all the functionalities and
has more advanced features. Since there are not any other fields in
trusted-resources-config we decided to remove it. Trusted resources is
alpha feature so the configmap can be deprecated with one release
notice.

Closes tektoncd#5852

Signed-off-by: Yongxuan Zhang [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants