Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline related function in taskrun_types.go #5320

Closed
JeromeJu opened this issue Aug 12, 2022 · 1 comment · Fixed by #5377
Closed

Refactor pipeline related function in taskrun_types.go #5320

JeromeJu opened this issue Aug 12, 2022 · 1 comment · Fixed by #5377
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Aug 12, 2022

This issue address that the IsPartOfPipeline func in taskrun_types does not seem to belong in the file. This should be refactored and essentially moved to pipeline related files.

Thanks @lbernick
Originally posted by @lbernick in #5264 (comment)

@tekton-robot
Copy link
Collaborator

@JeromeJu:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants