-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document running the pipeline tutorial on one's laptop #410
Comments
This is super awesome @a-roberts - I was recently on a plane and not thrilled with the idea of trying to upload images constantly via airplane wifi while working on the project - I didn't know we were so close to making it work with Docker for Desktop, now I want to give it a shot myself :)
I think I need to put some more detail into #235, but I think one key difference between #235 and this issue is that #235 would include being able to test changes to a git resource without having to push to a remote repo (maybe #235 needs to be more clearly scoped and broken up into some sub issues 🤔 ) |
Thanks for the input @bobcatfish, yep we only need to change a few things really. I agree it would be a great first issue, it would be awesome if somebody relatively new to knative (but perhaps not only myself as I could have fiddled with other components) were to follow what we come up with. Here's what I recall doing a few days ago, so we we'll want to either doc this via a new readme or do it via code comments (I like the latter approach, have easy to search for placeholders):
I think we should advocate having @mgreau's elasticsearch example deployed too to see the pod logs (useful to see our build logs after the fact, for convenience that's https://github.com/mgreau/knative-elastic-tutorials). Now that #414 is merged I would like to give the tutorial another go (sanity checking/validating the above steps as well). I did plenty of learning in the one day so may have added steps from other tutorials along the way. I'll take a look tomorrow if nobody beats me to it, I assume I'll need to build my own knative from source as there hasn't been a new release yet to pick up the changes. |
I'd like to work on this, @bobcatfish would you do the honours of assigning me please? I have some progress to share here, will ask a colleague to follow in my footsteps tomorrow 🤞 . |
@a-roberts can you please help me get pipeline controller deployed. I am trying deploying it on 3-node kube cluster. I am following the guidelines here, and set the environment variables properly. I am using local docker registry. When I run
I believe I need to change registry names at more places beyond just |
Hey @nadgowdas, you're best suited to asking in the Slack channels we have for this (so for convenience please see https://knative.slack.com, but with regards to the above problem that strikes me as not setting your Gopath and source code paths correctly. You will find useful information clues at the discussion I had on Slack here. The key part being:
So with the above steps you should have a local Docker registry running, you set KO_DOCKER_REPO, your folder structures are perfect, your Gopath is awesome and a ko apply goes and builds a bunch of images that are stored in our local registry and are used by build pipeline. Please check this is the case |
Thank you @a-roberts , moving this |
I think we've basically got this covered in our docs, but if I'm wrong we can re-open :) |
Fix dockerfile getting generated
I've noticed #235 too and that mentions an interest in running Knative and the pipelines locally (perhaps some information here could be used there, or this issue should be merged with another?).
Expected Behavior
It should be easy for anyone to follow the build pipeline tutorials on one's laptop - I've had good success using Docker for Desktop using the edge release, 4 CPUs and 8 GB of memory.
Actual Behavior
https://github.com/knative/build-pipeline/blob/master/docs/tutorial.md mentions
gcr.io
in a few places and the results are stored in stackdriver. Which this is awesome and shows how we could use a real cloud platform (which is where we want knative to be deployed!) I think we'll gain more attention and popularity by having knative more "hackable"; so we should lower the barrier to entry and make it trivial to use on one's laptop.Steps to Reproduce the Problem
Additional Info
I think this will be purely a docs contribution as everything works fine (apart from what we know is unimplemented already which is #216). This could be done with comments in the example code (e.g. adding todos where users should be replacing strings, and mentioning what things can/should be change and to what values).
The text was updated successfully, but these errors were encountered: