Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break Pipelines' dependency on Build #252

Closed
imjasonh opened this issue Nov 21, 2018 · 3 comments
Closed

Break Pipelines' dependency on Build #252

imjasonh opened this issue Nov 21, 2018 · 3 comments
Assignees
@vdemeester @imjasonh

Comments

@imjasonh
Copy link
Member

Today, when TaskRuns are created, they in turn create a Build, which creates a Pod. As the Pod executes, the Build status is updated, and in turn the TaskRun's status is updated.

Instead of all of this indirection, creating a TaskRun should simply create and watch a Pod, and update its status as it goes along.

This is dependent on the work in #243 so that TaskRunStatus has all of a BuildStatus' fields, and on knative/build#464 which simplifies the Build controller uses to create and watch for pod updates, making it simpler to forklift into the TaskRun controller.

/assign ImJasonH
@bobcatfish bobcatfish added this to the 0.3 Alpha release milestone Nov 21, 2018
@imjasonh imjasonh mentioned this issue Nov 26, 2018
Closed
This was referenced Nov 27, 2018
Closed
Closed
Closed
@bobcatfish
Copy link
Collaborator

Copying in @imjasonh 's sweet image from #326:

image

At this point we have gotten to Phase 1, next step will be Phase 2.

@bobcatfish bobcatfish removed this from the 0.4 Knative Release milestone Jan 23, 2019
@bobcatfish bobcatfish added okr This is for some internal Google project tracking and removed okr This is for some internal Google project tracking labels Feb 21, 2019
@vdemeester
Copy link
Member

/assign

@dlorenc
Copy link
Contributor

dlorenc commented Mar 8, 2019

/assign vdemeester

This was referenced Mar 19, 2019
Closed
Merged
Merged
pradeepitm12 pushed a commit to pradeepitm12/pipeline that referenced this issue Jan 28, 2021
@dibyom @tekton-robot
Split Test_NewResources into smaller tests
256c7e4 
We used to have a function called NewResources that we later split into
smaller functions -- ResolveParams and ResolveResources. However, in our
unit tests, we kept the Test_NewResources function leading to tests that
were more verbose/needed more setup than necessary. This commit splits
the tests into smaller more targeted tests.

Fixes tektoncd#252

Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdemeester vdemeester

@imjasonh imjasonh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vdemeester @imjasonh @bobcatfish @dlorenc