Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Types for PipelineRef and TaskRef #1498

Closed
danielhelfand opened this issue Oct 30, 2019 · 4 comments
Closed

Inconsistent Types for PipelineRef and TaskRef #1498

danielhelfand opened this issue Oct 30, 2019 · 4 comments
Labels
kind/question Issues or PRs that are questions around the project or a particular feature

Comments

@danielhelfand
Copy link
Member

While working with the Tekton API as part of the cli project, I was adding validation to the tkn tr describe and tkn pr describe commands to check whether the properties are present on taskrun and pipelinerun specs. For taskruns, I used a nil check to determine if the TaskRef is present. For pipelineruns, I had to used an empty string for PipelineRef.

I am wondering why TaskRef is defined as follows here:

TaskRef *TaskRef json:"taskRef,omitempty"

And why a different approach was taken with PipelineRef here:

PipelineRef PipelineRef json:"pipelineRef,omitempty"

What was the thought behind using the * operator for TaskRef whereas all other Refs do not?

@danielhelfand
Copy link
Member Author

/kind question

@tekton-robot tekton-robot added the kind/question Issues or PRs that are questions around the project or a particular feature label Oct 30, 2019
@vdemeester
Copy link
Member

Will be solved by #1495 and #1497

@vdemeester
Copy link
Member

Both pull-requests are merged, closing
/close

@tekton-robot
Copy link
Collaborator

@vdemeester: Closing this issue.

In response to this:

Both pull-requests are merged, closing
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Issues or PRs that are questions around the project or a particular feature
Projects
None yet
Development

No branches or pull requests

3 participants