Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PodSpec deprecated field in favor of PodTemplate #1070

Closed
vdemeester opened this issue Jul 12, 2019 · 3 comments
Closed

Remove PodSpec deprecated field in favor of PodTemplate #1070

vdemeester opened this issue Jul 12, 2019 · 3 comments
Assignees
@vdemeester
Milestone
Pipelines 0.7 🐱

Comments

@vdemeester
Copy link
Member

In #1004, we introduced podTemplate to group PodSpec fields applied to the created Pod. This means we marked some TaskRun field deprecated : NodeSelector, Tolerations and Affinity. As we want to make most change first in a backwards compatible manner, we are currently supporting both, with podTemplate taking precedence.

This issue should wait until #1004 has been released (probably in 0.6), and in the next version (probably 0.7) we can make the backwards incompatible change.
@vdemeester vdemeester added the maybe-next-milestone For consideration when planning the next milestone label Jul 12, 2019
@bobcatfish bobcatfish added this to the Pipelines 0.7 🐱 milestone Aug 12, 2019
@bobcatfish bobcatfish mentioned this issue Aug 20, 2019
Closed
@bobcatfish bobcatfish removed the maybe-next-milestone For consideration when planning the next milestone label Sep 6, 2019
@vdemeester
Copy link
Member Author

/assign

@bobcatfish bobcatfish mentioned this issue Sep 12, 2019
Merged
3 tasks
@vdemeester
Copy link
Member Author

/close

@tekton-robot
Copy link
Collaborator

@vdemeester: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdemeester vdemeester

Labels
None yet
Projects
None yet
Milestone
Pipelines 0.7 🐱
Development

No branches or pull requests
3 participants
@vdemeester @bobcatfish @tekton-robot