Skip to content

Commit

Permalink
Remove the "baseBuildOverrides" flag from .ko.yaml
Browse files Browse the repository at this point in the history
This section never actually worked in ko. See ko-build/ko#167
We don't appear to be setting the ldflags anywhere else, so maybe we don't need them?
  • Loading branch information
dlorenc authored and tekton-robot committed Jul 20, 2020
1 parent 11eeafb commit dc54332
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .ko.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,3 @@ baseImageOverrides:

# Our entrypoint image does not need root, it simply needs to be able to 'cp' the binary into a shared location.
github.com/tektoncd/pipeline/cmd/entrypoint: gcr.io/distroless/base:debug-nonroot
baseBuildOverrides:
github.com/tektoncd/pipeline/cmd/controller:
flags:
- name: ldflags
value: "-X github.com/tektoncd/pipeline/pkg/version.PipelineVersion=devel"

0 comments on commit dc54332

Please sign in to comment.