Skip to content

Commit

Permalink
Move templating package outside of reconcilier šŸµ
Browse files Browse the repository at this point in the history
It's completely independent of the reconcilier or the apis šŸ‘¼

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and knative-prow-robot committed Mar 4, 2019
1 parent 5456d20 commit 7c289d8
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkg/apis/pipeline/v1alpha1/pipeline_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"fmt"

"github.com/knative/build-pipeline/pkg/list"
"github.com/knative/build-pipeline/pkg/reconciler/v1alpha1/templating"
"github.com/knative/build-pipeline/pkg/templating"
"github.com/knative/pkg/apis"
"k8s.io/apimachinery/pkg/api/equality"
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/pipeline/v1alpha1/task_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"fmt"
"strings"

"github.com/knative/build-pipeline/pkg/reconciler/v1alpha1/templating"
"github.com/knative/build-pipeline/pkg/templating"
"github.com/knative/pkg/apis"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/equality"
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/v1alpha1/pipelinerun/resources/apply.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"fmt"

"github.com/knative/build-pipeline/pkg/apis/pipeline/v1alpha1"
"github.com/knative/build-pipeline/pkg/reconciler/v1alpha1/templating"
"github.com/knative/build-pipeline/pkg/templating"
)

// ApplyParameters applies the params from a PipelineRun.Params to a PipelineSpec.
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/v1alpha1/taskrun/resources/apply.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"fmt"

"github.com/knative/build-pipeline/pkg/apis/pipeline/v1alpha1"
"github.com/knative/build-pipeline/pkg/reconciler/v1alpha1/templating"
"github.com/knative/build-pipeline/pkg/templating"
buildv1alpha1 "github.com/knative/build/pkg/apis/build/v1alpha1"
)

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
"github.com/knative/pkg/apis"

"github.com/google/go-cmp/cmp"
"github.com/knative/build-pipeline/pkg/reconciler/v1alpha1/templating"
"github.com/knative/build-pipeline/pkg/templating"
)

func TestValidateVariables(t *testing.T) {
Expand Down

0 comments on commit 7c289d8

Please sign in to comment.