Skip to content

Commit

Permalink
Pass explicit platforms list when publishing images
Browse files Browse the repository at this point in the history
Prior to this commit the pipeline-release Pipeline relied on default
params to ensure that the publish-release task emits a windows
entrypoint image. It looks like this no longer works because the
dogfooding cluster is using alpha API fields, including implicit params.

With implicit params it is not possible to _skip_ a param in a PipelineTask if it
shares a name with a Param in the Pipeline. So before we were intentionally omitting the
platforms param and relying on the default param value in the
publish-release Task but with implicit params this is no longer
possible.

This commit overrides the param passed to publish-release with the full
string of platforms including windows. We don't want to update the
Pipeline's `platforms` param because our build-images
PipelineTask can't build the windows image. Confusing.
  • Loading branch information
Scott authored and tekton-robot committed Jan 13, 2022
1 parent f4c939c commit 56a9b03
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tekton/release-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,13 @@ spec:
value: $(params.releaseAsLatest)
- name: serviceAccountPath
value: $(params.serviceAccountPath)
# NOTE: We're purposefully *not* passing the pipeline's platforms to
# this task. We want to use the task's default platforms, which include
# windows.
- name: platforms
# Important: This param value includes windows, which differs
# from the platforms param defined at the top of this release
# pipeline. The reason for this is that the build-images
# PipelineTask doesn't build the windows base image, but the
# publish-release PipelineTask does.
value: linux/amd64,linux/arm,linux/arm64,linux/s390x,linux/ppc64le,windows/amd64
workspaces:
- name: source
workspace: workarea
Expand Down

0 comments on commit 56a9b03

Please sign in to comment.