[main] ignore enable-tekton-oci-bundles feature flag #2344
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
Signed-off-by: Jeeva Kandasamy <[email protected]>
jkandasa
force-pushed
the
ignore_EnableTektonOciBundles
branch
from
6c8b627
to
d1d1b68
Compare
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-operator-integration-tests |
| // not in use, see: https://github.com/tektoncd/pipeline/pull/7789 | ||
| // this field is removed from pipeline component | ||
| // keeping here to maintain the API compatibility | ||
| EnableTektonOciBundles *bool `json:"enable-tekton-oci-bundles,omitempty"` |
There was a problem hiding this comment.
So in the next or later release we can directly remove this field right from the API, since we are setting this to nil in defaulting ?
There was a problem hiding this comment.
@PuneetPunamiya we never remove this from v1alpha1 API
| // not in use, see: https://github.com/tektoncd/pipeline/pull/7789 | ||
| // this field is removed from pipeline component | ||
| // keeping in types to maintain the API compatibility |
There was a problem hiding this comment.
I think we don't need this comment here
|
Thanks 🤙🏻 |
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
tested fresh and upgrade scenario works fine Thank you @PuneetPunamiya lets merge when your comment #2344 (comment) resolve |
As per the discussion with Puneet merging this PR now /lgtm |
|
/cherry-pick release-v0.73.x |
|
@savitaashture: once the present PR merges, I will cherry-pick it on top of release-v0.73.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@savitaashture: new pull request created: #2351 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
enable-tekton-oci-bundlessupport removed and added into main stream. Supplyingenable-tekton-oci-bundles=truecan lead issue with pipeline controller. Hence ignoreenable-tekton-oci-bundlesvalues from TektonConfig CR and/or TektonPipelines CR.enable-tekton-oci-bundlesin operator to maintain the API compatibilitySubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes