Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jkhelil to owners file #2122

Merged
merged 1 commit into from
May 28, 2024
Merged

add jkhelil to owners file #2122

merged 1 commit into from
May 28, 2024

Conversation

jkhelil
Copy link
Member

@jkhelil jkhelil commented Apr 22, 2024

Changes

Add jkhelil to Owners file

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 22, 2024
@tekton-robot
Copy link
Contributor

Hi @jkhelil. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2024
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Apr 22, 2024
@jkhelil
Copy link
Member Author

jkhelil commented Apr 22, 2024

hey @jkandasa, can you have a look please.
Thank you

@jkandasa
Copy link
Member

@jkhelil thanks for the PR
AFAIK, we can not add a user into approver and/or reviewer list immediately.
users has to be satisfied the requirements from https://github.com/tektoncd/community/blob/main/process/contributor-ladder.md

cc @tektoncd/operator-maintainers

@piyush-garg
Copy link
Contributor

/verify-owners

2 similar comments
@piyush-garg
Copy link
Contributor

/verify-owners

@piyush-garg
Copy link
Contributor

/verify-owners

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2024
@piyush-garg
Copy link
Contributor

/verify-owners

1 similar comment
@piyush-garg
Copy link
Contributor

/verify-owners

@jkhelil
Copy link
Member Author

jkhelil commented May 21, 2024

/retest

@jkhelil
Copy link
Member Author

jkhelil commented May 21, 2024

/verify-owners

@tekton-robot tekton-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 21, 2024
@vdemeester
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@khrm
Copy link
Contributor

khrm commented May 21, 2024

/hold
@vdemeester I think @jkhelil doesn't satisy the owner condition. That's why it was on hold.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@jkandasa
Copy link
Member

/verify-owners

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@piyush-garg
Copy link
Contributor

/retest

@piyush-garg
Copy link
Contributor

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@tekton-robot tekton-robot merged commit a6de512 into tektoncd:main May 28, 2024
8 checks passed
@jkandasa
Copy link
Member

/cherry-pick release-v0.71.x

1 similar comment
@jkandasa
Copy link
Member

/cherry-pick release-v0.71.x

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #2202

In response to this:

/cherry-pick release-v0.71.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants