Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to mount config.yaml via ConfigMap #425

Closed
wants to merge 1 commit into from

Conversation

vinamra28
Copy link
Member

Changes

This commit adds the docs of reading config.yaml from a ConfigMap
instead of fetching it from a remote server.

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from sm43 and sthaha April 1, 2022 05:59
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2022
This commit adds the docs of reading config.yaml from a ConfigMap
instead of fetching it from a remote server.

Signed-off-by: vinamra28 <[email protected]>
@vinamra28
Copy link
Member Author

/retest

@vinamra28
Copy link
Member Author

got to know that there are some plans around it
/close

@tekton-robot
Copy link

@vinamra28: Closed this PR.

In response to this:

got to know that there are some plans around it
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vinamra28 vinamra28 deleted the docs-mount-config-as-file branch May 8, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants