This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
[workflows] POC using Knative GitHub eventsource #928
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a POC for using Knative GitHub eventsource to create a webhook on a repo declared in a new repo CRD, given a personal access token and webhook secret. The sink for the GitHub eventsource is the Workflows eventlistener.
The user is expected to create a GitRepository with references to the necessary credentials before creating the Workflow. The GitHub eventsource connection status is reflected on the GitRepository.
The GitHub eventsource validates payloads coming from GitHub, so this functionality is removed from the generated workflow trigger. An interceptor is added to filter to only the repo of interest, assuming GitHub event payloads.
This commit also adds substitution for parameters of the form $(repos.foo.url).
Benefits:
Not yet implemented:
Challenges:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.