-
Notifications
You must be signed in to change notification settings - Fork 121
Use go-containerregistry to push and pull #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpicks.
Also, I tried to check this out and run it locally on a simple pipeline. It hung for a long time and didn't give much indication what it was doing. Might be worth looking into a way to print out what is going on.
Hmm, I'm not sure what would cause this to hang, since it's basically just a bunch of small HTTP requests and tar operations. Maybe auth is the culprit? google/go-containerregistry#670 tracks upload/download progress repoprting in go-containerregistry, but I'm not sure there's much movement yet. |
/test tekton-experimental-unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierretasci, sthaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using this library should make it easier to integrate with Tekton controller components when the time comes.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.