Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Use go-containerregistry to push and pull #468

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Feb 18, 2020

Using this library should make it easier to integrate with Tekton controller components when the time comes.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 18, 2020
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2020
@imjasonh imjasonh changed the title WIP: Use go-containerregistry to push and pull Use go-containerregistry to push and pull Feb 20, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2020
Copy link

@pierretasci pierretasci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks.

Also, I tried to check this out and run it locally on a simple pipeline. It hung for a long time and didn't give much indication what it was doing. Might be worth looking into a way to print out what is going on.

oci/pkg/oci/image.go Outdated Show resolved Hide resolved
oci/pkg/oci/image.go Show resolved Hide resolved
@imjasonh
Copy link
Member Author

imjasonh commented Feb 21, 2020

Also, I tried to check this out and run it locally on a simple pipeline. It hung for a long time and didn't give much indication what it was doing. Might be worth looking into a way to print out what is going on.

Hmm, I'm not sure what would cause this to hang, since it's basically just a bunch of small HTTP requests and tar operations. Maybe auth is the culprit?

google/go-containerregistry#670 tracks upload/download progress repoprting in go-containerregistry, but I'm not sure there's much movement yet.

@imjasonh
Copy link
Member Author

/test tekton-experimental-unit-tests

Copy link

@pierretasci pierretasci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sthaha
Copy link
Member

sthaha commented Feb 24, 2020

/lgtm
/approve

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierretasci, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 81a024e into tektoncd:master Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants