Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task-loops] Remove max parallel TaskRuns in Task Loops #804

Closed
jerop opened this issue Oct 15, 2021 · 8 comments
Closed

[task-loops] Remove max parallel TaskRuns in Task Loops #804

jerop opened this issue Oct 15, 2021 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jerop
Copy link
Member

jerop commented Oct 15, 2021

today, we provide concurrency controls in looping custom task - https://github.com/tektoncd/experimental/tree/main/task-loops#specifying-concurrency

controlling max parallel taskruns is an issue that came up more broadly for pipelines in tektoncd/pipeline#2591

as we're explore stabilizing this custom task, we need to figure out how to handle this concurrency control

preferably, we can remove it from looping custom tasks then we can explore if and how we want to control max parallel taskruns in general (not just in looping)

if you're using the concurrency controls in the looping custom task, please share your use cases and experiences

@jerop
Copy link
Member Author

jerop commented Oct 15, 2021

/cc @pritidesai @bobcatfish
/assign

@pritidesai
Copy link
Member

pritidesai commented Oct 15, 2021

hey @Tomcli, do you utilize concurrency feature in a task loop custom task?

We are designing the proposal for promoting task loop and introducing it as part of the core API. We are looking for the use cases if its being utilized, otherwise we can relay it as a pipeline level feature.

EDIT: Link to the TEP: tektoncd/community#532

@Tomcli
Copy link

Tomcli commented Oct 15, 2021

Thanks @pritidesai, I think the concurrency was introduced because the core Tekton API didn't support concurrency within the pipeline scope. If the concurrency feature already available within pipelines and able to limit the numbers of taskrun and run, we can remove this feature in the taskloop custom task.

@jerop jerop changed the title [task-loops] remove concurrency controls in looping [task-loops] Remove max parallel TaskRuns in Task Loops Oct 18, 2021
@jerop jerop removed their assignment Dec 16, 2021
@afrittoli
Copy link
Member

I don't think we should remove a feature on the base of a future improvement that, if implemented, might provide a similar functionality.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2022
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 2, 2022
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants