-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort items in namespace drop down by name #2270
Sort items in namespace drop down by name #2270
Conversation
Hi @SaschaSchwarze0. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR @SaschaSchwarze0. Can you share more details about the environment you're seeing this in? I'm seeing the namespaces displayed in sorted order without this change, see for example our dogfooding cluster: https://dashboard.dogfooding.tekton.dev/#/pipelines |
Hi @AlanGreene, sure, I am using microk8s. Here is parts of my drop down: It is kind of sorted in the order the namespaces were created, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to reproduce the issue in my test environments but the change is safe and solves a problem that may affect other users.
Just one potential issue with the test, otherwise this looks good 👍
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows users to find an item easier once the list becomes longer.
7bf4173
to
3c575ac
Compare
Thanks again for the PR |
Changes
The longer list of items in the Namespace drop down is sometimes driving me crazy to find what I look for. Changing it to show items sorted to make that easier.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: