Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort items in namespace drop down by name #2270

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

SaschaSchwarze0
Copy link
Contributor

Changes

The longer list of items in the Namespace drop down is sometimes driving me crazy to find what I look for. Changing it to show items sorted to make that easier.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 4, 2022
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2022
@tekton-robot
Copy link
Contributor

Hi @SaschaSchwarze0. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

Thanks for the PR @SaschaSchwarze0. Can you share more details about the environment you're seeing this in? I'm seeing the namespaces displayed in sorted order without this change, see for example our dogfooding cluster: https://dashboard.dogfooding.tekton.dev/#/pipelines

@SaschaSchwarze0
Copy link
Contributor Author

Thanks for the PR @SaschaSchwarze0. Can you share more details about the environment you're seeing this in? I'm seeing the namespaces displayed in sorted order without this change, see for example our dogfooding cluster: https://dashboard.dogfooding.tekton.dev/#/pipelines

Hi @AlanGreene, sure, I am using microk8s. Here is parts of my drop down:

grafik

It is kind of sorted in the order the namespaces were created, I think.

Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to reproduce the issue in my test environments but the change is safe and solves a problem that may affect other users.

Just one potential issue with the test, otherwise this looks good 👍

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
This allows users to find an item easier once the list becomes longer.
@AlanGreene
Copy link
Member

Thanks again for the PR
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@tekton-robot tekton-robot merged commit 89784c0 into tektoncd:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants