-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pagination and sorting method #842
Comments
Here's a good test case with over 3,000 PipelineResources: From https://dashboard.dogfooding.tekton.dev/#/pipelineruns (@afrittoli the contact who's set this up 🎈 ) so it's definitely something to look into |
https://kubernetes.io/docs/reference/using-api/api-concepts/#retrieving-large-results-sets-in-chunks The Kubernetes API supports chunking, which would allow us to limit the number of resources loaded in a single request. If we just load the first (large, size TBD) chunk for each type, we could ensure a more responsive UI for these cases with many resources. Obviously this means the user doesn't have access to all resources in the UI unless the resources are labelled and the user knows the correct labels to filter on. I think we need to do some more brainstorming around this, both from a technical and design perspective. |
/assign |
I've had a look into this as well - chunking with the KubeAPI seems perfectly possible however carbon doesn't currently support easy integration between pagination and data tables using react, so not sure how easy this would be to do. |
This should also include ensuring the strings for the sorting headers are extracted for translation, see https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/DataTable/TableHeader.js and
|
/assign |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected Behavior
As a Tekton Dashboard user I should be able to sort/view records without suffering from poor performance (in terms of animations and rendering) so that I don't have a dreadful and frustrating experience
Actual Behavior
No such sorting or pagination exists
Steps to Reproduce the Problem
Additional Info
To be investigated before #833
The text was updated successfully, but these errors were encountered: