Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TaskTree design #1775

Closed
AlanGreene opened this issue Oct 15, 2020 · 6 comments · Fixed by #1822
Closed

Update TaskTree design #1775

AlanGreene opened this issue Oct 15, 2020 · 6 comments · Fixed by #1822
Assignees
Labels
kind/design Categorizes issue or PR as related to design.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Oct 15, 2020

Extracted from #1445 (comment)

Update the design of the TaskTree component to:

  • reduce use of heavy block colours
  • make it easier to see status of multiple TaskRuns / steps
  • etc.

Here's a rough mockup of the proposed design:
image

There are still some details to be worked out but I think this would be a nice improvement.

@AlanGreene
Copy link
Member Author

/kind design

@tekton-robot tekton-robot added the kind/design Categorizes issue or PR as related to design. label Oct 15, 2020
@AlanGreene
Copy link
Member Author

StatusIcon component has been updated and provides 2 styles: default and 'inverse'.
The inverse style currently uses a white fill and is intended for use on the block colour backgrounds.
With the new design this can switch to the outline style instead. May need a minor update to remove the exclusions.

@AlanGreene
Copy link
Member Author

/assign

@AlanGreene
Copy link
Member Author

I have the initial updates mostly complete but will hold off on the PR until after the next Dashboard release to avoid holding up getting some important fixes out (e.g. rerunning cancelled runs #1788)

@AlanGreene
Copy link
Member Author

Some focus states still need to be updated, e.g. selected step, but otherwise it's nearly there.
image

I've made some changes to StatusIcon size and positioning.

This first pass maintains the existing behaviour of only having a single TaskRun expanded at a time. A future update will add the chevron to allow multiple to be expanded at the same.

@AlanGreene
Copy link
Member Author

PR #1806 with the initial design update is merged, will check it out on robocat after the next nightly deploy.

The next step is to support expanding multiple TaskRuns at the same time so the user can see summary of step status without having to switch between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants