Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of steps in pipeline runs view #1729

Closed
didier-durand opened this issue Sep 26, 2020 · 10 comments
Closed

number of steps in pipeline runs view #1729

didier-durand opened this issue Sep 26, 2020 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@didier-durand
Copy link

didier-durand commented Sep 26, 2020

Hello,

Possible to add the number of steps executed in pipeline run view?

I'd see it for example before or after "Duration" in screenshot below. Maybe they should be displayed as X/Y where X is the number of successful steps and Y the total.

Thanks!

Didier

image

@didier-durand didier-durand added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2020
@AlanGreene
Copy link
Member

Thanks for the request @didier-durand. We already provide this information in a number of places.
image

This is the same message displayed on the PipelineRun details page
image

The message comes from the PipelineRun status field:

$ kubectl get -ojson pr check-pr-labels-rf8nw | jq '.status.conditions[0].message'
"Tasks Completed: 1 (Failed: 0, Cancelled 0), Skipped: 0"

Is this sufficient for your needs or are you looking for a more prominent display of this information on the PipelineRuns list specifically?

@didier-durand
Copy link
Author

Hi @AlanGreene,

I have seen that I can zoom on a PipelineRun via a click to get a list of tasks that were run as part of this pipeline. It's ok when you have a few pipelines. But, when you've many of them, you want a synthetic view of each pipeline at top level. That's why I believe that the PipelineRuns view should also provide the total number of tasks and the successful ones at top level in the dashboard : you want to make most efficient for DevOps teams.

If I may, I would also suggest some improvements for the task view when you click on a given PipelineRun: I would suggest something very much like display of tracing spans by Jaeger with time axis as horizontal as tasks represented on this time axis according to their start and stop time to provide a view where tasks are positionned on the time line.

Didier

@AlanGreene
Copy link
Member

Note to self / future developers: Also relevant here is some of the previous discussion / design exploration around presentation of the status and status message: #775 and other issues. This might be a good opportunity to revisit this and see what additional information would make sense here and how best it can be displayed without making the list views overly busy.

@didier-durand can you expand on your second point about the 'tracing spans'? We're planning a PipelineRun visualisation which would show the directed acyclic graph generated by the Pipeline execution. This would be similar in function to visualisations provided in many other CD/CI tools.

Do you see the 'tracing spans' fulfilling a similar function? What additional / alternative benefit do they provide? How would a user make use of them? I'd love to understand this better so we can make more informed decisions about the future designs for the Dashboard.

@didier-durand
Copy link
Author

@AlanGreene : I have seen the PipelineRun visualisation that you prepare. It is clearly a good thing to show a pipeline as a DAG. My point is different and complementary: basically, I suggest to add a time axis to the DAG in order to see how long after start a Task X was started and how much it lasted.

That is the reason of my analogy with distributed trace spans

distributed-trace

In the above image, you can see when an additional trace happens and how long the interaction lasts.

That's what I would like to see in Tekton UI in order to spot easily the tasks that make the pipeline run for (too) long.

In your current DAG view, you can probably achieve that by correlating the length of the arrow with the delay until start and the length of the box with the task duration.

If I remain unclear, please, don't hesitate to ask additional questions

Didier

@AlanGreene
Copy link
Member

Thanks for the additional information, that helps to understand a possible use case for something like this.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2021
@didier-durand
Copy link
Author

@AlanGreene : any progress / decision regarding the implementation of this use case? Best,Didier

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2021
@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants