Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying git revision on Import Resources form #1550

Closed
AlanGreene opened this issue Jun 22, 2020 · 7 comments · Fixed by #1979
Closed

Add support for specifying git revision on Import Resources form #1550

AlanGreene opened this issue Jun 22, 2020 · 7 comments · Fixed by #1979
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@AlanGreene
Copy link
Member

Is your feature request related to a problem ?

Import Resources is currently hardcoded to import from the master branch of the repository specified. This means users cannot reference Tekton resources from other branches or take advantage of standard git versioning approaches (e.g. tags) to maintain their pipeline definitions when used with this feature.

Describe the solution you'd like

The Import Resources form should include input(s) to allow specifying the git revision desired.

See tektoncd/pipeline#2320 and https://github.com/tektoncd/pipeline/blob/master/docs/resources.md for details of the revision and refspec (optional) fields on the git PipelineResource.

Also tektoncd/pipeline#2822 for related discussion about defaults.

Describe alternatives you've considered

Additional context

@AlanGreene AlanGreene added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 22, 2020
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member Author

/remove-lifecycle rotten
/reopen

@tekton-robot tekton-robot reopened this Aug 15, 2020
@tekton-robot
Copy link
Contributor

@AlanGreene: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member Author

Import Resources is currently using a git PipelineResource. We may want to consider removing this and moving to an alternative implementation given PipelineResources are still alpha and may be deprecated and removed in a future Pipelines release.

There's a git-clone Task in the catalog that was designed as a replacement for the git PipelineResource. It supports revision, refSpec, and a number of other params that may be useful.

How would we use this Task? Bundle the Task with the Dashboard install as we used to do with our pipeline0?

@AlanGreene
Copy link
Member Author

Another approach to using the git-clone Task without having to ship it with the Dashboard would be to use Tekton Bundles, however support for this is currently disabled by default in Tekton Pipelines tektoncd/pipeline#3661. There's also a feature request to have Tasks from the catalog automatically published as bundles tektoncd/catalog#577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants